[KYUUBI-7316] Fix parsePropertyFromUrl to remove query string from parsed values by wangyum · Pull Request #7317 · apache/kyuubi

wangyum · 2026-01-29T08:34:02Z

Why are the changes needed?

Fixed the parsePropertyFromUrl method in Utils.java to properly remove query string parts (everything after ?) from parsed JDBC URL property values, making it consistent with the extractURLComponents method.

When parsing JDBC URLs with query strings like: jdbc:hive2://host:10012/db;auth=JWT?kyuubi.session.cluster=clusterA.
The parsePropertyFromUrl method was incorrectly returning JWT?kyuubi.session.cluster=clusterA for the auth property, while extractURLComponents correctly returned only JWT. This inconsistency could cause authentication failures in JWT auth scenarios with additional query parameters.

How was this patch tested?

URLs with query strings parse properties correctly without the query string
URLs without query strings continue to work as expected
Both parsing methods return consistent results

Was this patch authored or co-authored using generative AI tooling?

No.

codecov-commenter · 2026-01-29T09:53:17Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (dfd9b49) to head (e89260c).

Files with missing lines	Patch %	Lines
...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #7317   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         698     698           
  Lines       43654   43658    +4     
  Branches     5896    5897    +1     
======================================
- Misses      43654   43658    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR fixes an inconsistency in JDBC URL property parsing where parsePropertyFromUrl was incorrectly including query string parameters in property values while extractURLComponents correctly excluded them. This could cause authentication failures when using JWT auth with additional query parameters.

Changes:

Modified parsePropertyFromUrl to strip query string portions (everything after ?) from parsed property values
Added comprehensive test coverage for both query string and non-query string scenarios
Ensured both parsing methods return consistent results

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java	Updated `parsePropertyFromUrl` to remove query string parameters from property values
kyuubi-hive-jdbc/src/test/java/org/apache/kyuubi/jdbc/hive/UtilsTest.java	Added tests verifying consistency between parsing methods and correct handling of query strings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T17:07:19Z

kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java

+        String value = token.trim().substring((key.trim() + "=").length());
+        // Remove query string part (anything after ?) to match extractURLComponents behavior
+        int queryIndex = value.indexOf('?');
+        if (queryIndex > 0) {


The condition queryIndex > 0 will fail to handle query strings at the start of the value (e.g., ?param=value). Change the condition to queryIndex >= 0 to correctly handle all cases where a query string is present, including when it appears at position 0.

Suggested change

if (queryIndex > 0) {

if (queryIndex >= 0) {

@copilot-pull-request-reviewer could you also add a test ?

@Copilot could you also add a test ?

turboFei · 2026-01-29T17:10:33Z

kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java

-        return token.trim().substring((key.trim() + "=").length());
+        String value = token.trim().substring((key.trim() + "=").length());
+        // Remove query string part (anything after ?) to match extractURLComponents behavior
+        int queryIndex = value.indexOf('?');


kyuubi/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java

Lines 482 to 514 in dfd9b49

/**

* Get the authority string from the supplied uri, which could potentially contain multiple

* host:port pairs.

*/

private static String getAuthorityFromJdbcURL(String uri) throws JdbcUriParseException {

String authorities;

/*

* For a jdbc uri like:

* jdbc:hive2://<host1>:<port1>,<host2>:<port2>/dbName;sess_var_list?conf_list#var_list Extract

* the uri host:port list starting after "jdbc:hive2://", till the 1st "/" or "?" or "#"

* whichever comes first & in the given order Examples:

* jdbc:hive2://host1:port1,host2:port2,host3:port3/db;k1=v1?k2=v2#k3=v3

* jdbc:hive2://host1:port1,host2:port2,host3:port3/;k1=v1?k2=v2#k3=v3

* jdbc:hive2://host1:port1,host2:port2,host3:port3?k2=v2#k3=v3

* jdbc:hive2://host1:port1,host2:port2,host3:port3#k3=v3

*/

String matchedUrlPrefix = getMatchedUrlPrefix(uri);

int fromIndex = matchedUrlPrefix.length();

int toIndex = -1;

ArrayList<String> toIndexChars = new ArrayList<>(Arrays.asList("/", "?", "#"));

for (String toIndexChar : toIndexChars) {

toIndex = uri.indexOf(toIndexChar, fromIndex);

if (toIndex > 0) {

break;

}

}

if (toIndex < 0) {

authorities = uri.substring(fromIndex);

} else {

authorities = uri.substring(fromIndex, toIndex);

}

return authorities;

}

see https://kyuubi.readthedocs.io/en/master/client/jdbc/kyuubi_jdbc.html#basic-connection-url-format

jdbc:subprotocol://host:port[/catalog]/[schema];<clientProperties;><[#|?]sessionProperties>

We can parse the clientProperties only to get auth property

fix

206f28d

github-actions bot added module:hive module:ctl labels Jan 29, 2026

fix

e89260c

turboFei requested a review from Copilot January 29, 2026 17:06

Copilot AI reviewed Jan 29, 2026

View reviewed changes

turboFei reviewed Jan 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KYUUBI-7316] Fix parsePropertyFromUrl to remove query string from parsed values#7317

[KYUUBI-7316] Fix parsePropertyFromUrl to remove query string from parsed values#7317
wangyum wants to merge 2 commits intoapache:masterfrom
wangyum:KYUUBI-7316

wangyum commented Jan 29, 2026

Uh oh!

codecov-commenter commented Jan 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

wangyum Jan 30, 2026

Uh oh!

wangyum Jan 30, 2026

Uh oh!

turboFei Jan 29, 2026

Uh oh!

turboFei Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/**
	* Get the authority string from the supplied uri, which could potentially contain multiple
	* host:port pairs.
	*/
	private static String getAuthorityFromJdbcURL(String uri) throws JdbcUriParseException {
	String authorities;
	/*
	* For a jdbc uri like:
	* jdbc:hive2://<host1>:<port1>,<host2>:<port2>/dbName;sess_var_list?conf_list#var_list Extract
	* the uri host:port list starting after "jdbc:hive2://", till the 1st "/" or "?" or "#"
	* whichever comes first & in the given order Examples:
	* jdbc:hive2://host1:port1,host2:port2,host3:port3/db;k1=v1?k2=v2#k3=v3
	* jdbc:hive2://host1:port1,host2:port2,host3:port3/;k1=v1?k2=v2#k3=v3
	* jdbc:hive2://host1:port1,host2:port2,host3:port3?k2=v2#k3=v3
	* jdbc:hive2://host1:port1,host2:port2,host3:port3#k3=v3
	*/
	String matchedUrlPrefix = getMatchedUrlPrefix(uri);
	int fromIndex = matchedUrlPrefix.length();
	int toIndex = -1;
	ArrayList<String> toIndexChars = new ArrayList<>(Arrays.asList("/", "?", "#"));
	for (String toIndexChar : toIndexChars) {
	toIndex = uri.indexOf(toIndexChar, fromIndex);
	if (toIndex > 0) {
	break;
	}
	}
	if (toIndex < 0) {
	authorities = uri.substring(fromIndex);
	} else {
	authorities = uri.substring(fromIndex, toIndex);
	}
	return authorities;
	}

Conversation

wangyum commented Jan 29, 2026

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

codecov-commenter commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

wangyum Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

wangyum Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

turboFei Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

turboFei Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Jan 29, 2026 •

edited

Loading